Skip to content

🐛 Set key, version and label columns as temporarily nullable #7067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

🐛 Set key, version and label columns as temporarily nullable #7067

merged 1 commit into from
Jan 22, 2025

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jan 22, 2025 •
edited
Loading

What do these changes do?

Fix an issue when migrating a DB with already existing project_nodes in it.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jan 22, 2025
@giancarloromeo giancarloromeo self-assigned this Jan 22, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.59%. Comparing base (0273e7c) to head (68d47f2).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7067      +/-   ##
==========================================
+ Coverage   85.57%   88.59%   +3.02%     
==========================================
  Files        1634     1395     -239     
  Lines       64261    56017    -8244     
  Branches     2050      902    -1148     
==========================================
- Hits        54992    49631    -5361     
+ Misses       8932     6229    -2703     
+ Partials      337      157     -180
Flag Coverage Δ
integrationtests 63.69% <ø> (+0.01%) ⬆️
unittests 86.70% <ø> (+2.85%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.43% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.41% <ø> (ø)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.45% <ø> (ø)
api_server 90.54% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.66% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.51% <ø> (ø)
director_v2 91.30% <ø> (+0.01%) ⬆️
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.39% <ø> (ø)
invitations 93.42% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.06% <ø> (-0.12%) ⬇️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.54% <ø> (+5.13%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0273e7c...68d47f2. Read the comment docs.

@giancarloromeo giancarloromeo added this to the Singularity milestone Jan 22, 2025
@giancarloromeo giancarloromeo marked this pull request as ready for review January 22, 2025 10:20
odeimaiz
odeimaiz approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixed my deployment 👌

@mrnicegyu11 mrnicegyu11 merged commit da83fb7 into ITISFoundation:master Jan 22, 2025
87 of 91 checks passed
@giancarloromeo giancarloromeo deleted the fix/projects-nodes-nullable-columns branch January 22, 2025 10:36
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 30, 2025
Closed
16 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@giancarloromeo giancarloromeo

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Singularity

Development

Successfully merging this pull request may close these issues.

5 participants

@giancarloromeo @pcrespov @odeimaiz @matusdrobuliak66 @mrnicegyu11